Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Correct product version in http user agent #12061

Merged
merged 4 commits into from
May 19, 2023
Merged

[dotnet] Correct product version in http user agent #12061

merged 4 commits into from
May 19, 2023

Conversation

nvborisenko
Copy link
Member

Description

It puts correct version in http request header like 4.9.1 rather than 4.0.0. Assembly version is still 4.0.0 which is correct. It is achieved via AssemblyInformationalVersion attribute set in bazel.

Motivation and Context

Highlight correct product version to track usage of selenium.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nvborisenko!

@diemol diemol merged commit 94303e0 into SeleniumHQ:trunk May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants