Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release logic #197

Merged
merged 1 commit into from
Jun 4, 2024
Merged

ci: fix release logic #197

merged 1 commit into from
Jun 4, 2024

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Jun 4, 2024

Contributor Comments

This aligns the version stored in __init__.py with the latest release tag so that bumpversion can release properly.

Manual Testing

Ran task release successfully in my local env.

Pull Request Checklist

Thank you for submitting a contribution to our project!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch.
  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • If there is an issue associated with your Pull Request, link the issue to the PR.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salacious has reviewed your code, please see inline comments.

code_reviews/__init__.py Show resolved Hide resolved
Copy link
Contributor

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChiefHolland ChiefHolland merged commit 7cb4843 into main Jun 4, 2024
3 checks passed
@ChiefHolland ChiefHolland deleted the fix-releases branch June 4, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants