Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail open when not running on a PR #196

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Jun 3, 2024

Contributor Comments

This fails open instead of failing closed when the goat runs in a github action but isn't a PR.

Pull Request Checklist

Thank you for submitting a contribution to our project!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch.
  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • If there is an issue associated with your Pull Request, link the issue to the PR.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

@JonZeolla JonZeolla enabled auto-merge (squash) June 3, 2024 20:41
Copy link
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla merged commit de140fe into main Jun 3, 2024
3 checks passed
@JonZeolla JonZeolla deleted the fix/branch-logic branch June 3, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants