Force Client Logout / Early test #700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update local
Update local
Added call to LuaBot for testing. Message sends to client but nothing happens.
broxen
reviewed
Nov 20, 2018
This comment has been minimized.
This comment has been minimized.
Changed file name to match class as well.
\forcelogout player_name message
broxen
requested changes
Nov 20, 2018
| return; | ||
| } | ||
|
|
||
| sendForceLogout(sess, parts[1].toUtf8(), parts[2].toUtf8()); |
There was a problem hiding this comment.
This will cut off longer messages like /forceLogout $target "I'm kicking you with this longer message, but it will get cut off, even if I wrap it in quotes" as parts[2] will equal "I'm
One solution would be to follow the format of cmdHandler_InfoMessage() to capture anything after the 2nd space in the string.
|
|
||
| if(parts.size() < 2) | ||
| { | ||
| qCDebug(logSlashCommand) << "Bad invocation: " << cmd; |
There was a problem hiding this comment.
I apologize, because I set the example with this "bad invocation" output, but the truth is that we should be more verbose with our error feedback.
I would describe the format this slash command expects so that users know what they should type
Sending all of the logout message. Updated error message to show example of slash command
30 tasks
broxen
approved these changes
Nov 22, 2018
The slash command now works. No sense to add it for LuaBot for now. /forceLogout playername disconnect message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the code to LuaBot to kick the player that selected it.
Will need to add the option to enter player name or show listed of players, like the mapmenu?