Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug and cleaned up the code in continue_from section of train.py #92

Merged
merged 2 commits into from
Jun 16, 2017

Conversation

SiddGururani
Copy link
Contributor

Rebased my fork of the repo with the new changes and tested out some logging features. There appears to have been a bug in this line:

loss_results, cer_results, wer_results = package['loss_results'], package['cer_results'], package[
                'wer_results']

The variables loss_results, etc are all of length args.epoch and so tensorboard logs had the full tensor logged instead of only the values up until start_epoch. My bad, because I was the one who wrote that piece of code. I think I fixed it at some point and forgot to submit another pull request.

@SiddGururani SiddGururani changed the title Fixed a bug and cleaned up the code in continue from section of train.py Fixed a bug and cleaned up the code in continue_from section of train.py Jun 16, 2017
@SeanNaren SeanNaren merged commit dba0e06 into SeanNaren:master Jun 16, 2017
@SeanNaren
Copy link
Owner

thanks for taking the time to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants