Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cont. Check constraint #567

Merged
merged 3 commits into from
Dec 26, 2022
Merged

Cont. Check constraint #567

merged 3 commits into from
Dec 26, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Dec 23, 2022 •
edited
Loading

PR Info

New Features

  • Create check constraint on column definition and table
  • Add check constraint on table alter statement

LemarAb and others added 2 commits December 23, 2022 15:13
@LemarAb
Check constraint (#542)
76e1ef7 
* check support added to ColumnDef and TableCreate

* test

* figuring out who forked

* changing author

* reverting unnec. changes

* now Check accepts SimpleExpr only

* add brackets to check

* Table level checks as vec

Co-authored-by: lemarabawi <[email protected]>
@billy1624
Refactoring
2ee7ab1
@billy1624 billy1624 self-assigned this Dec 23, 2022
@billy1624
Copy link
Member Author

Testing on live db:

@billy1624 billy1624 marked this pull request as ready for review December 23, 2022 07:28
@billy1624
Copy link
Member Author

Hey @LemarAb, please check :D

ikrivosheev
ikrivosheev reviewed Dec 23, 2022
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy1624 thank you! One comment (question).

src/backend/table_builder.rs Outdated Show resolved Hide resolved
@ikrivosheev ikrivosheev merged commit 5e6d592 into master Dec 26, 2022
@ikrivosheev ikrivosheev deleted the check_constraint branch December 26, 2022 11:46
@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev left review comments

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Table CHECK Constraints
3 participants
@billy1624 @ikrivosheev @LemarAb