Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#484 Iden static #508

Merged

Conversation

ikrivosheev
Copy link
Member

PR Info

New Features

  • Create trait IdenStatic

@ikrivosheev ikrivosheev self-assigned this Nov 6, 2022
@ikrivosheev
Copy link
Member Author

@nitnelave @tyt2y3 @billy1624 can you review my PR?

src/types.rs Outdated Show resolved Hide resolved
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. I have a feeling like SeaQuery will be slowly more-and-more like SeaORM

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @ikrivosheev

@ikrivosheev
Copy link
Member Author

Nice addition. I have a feeling like SeaQuery will be slowly more-and-more like SeaORM

I think this is good. I would like the SeaQuery to be the best query builder) And SeaORM - ORM and SeaQuery helps it for build query) This is one part of this.

sea-query-derive/tests/pass/renaming_table.rs Outdated Show resolved Hide resolved
@billy1624
Copy link
Member

Hey @tyt2y3, I wonder why we need to move below into SeaQuery? Any good reasons?

pub trait IdenStatic: Iden + Copy + Debug + 'static {
    /// Method to call to get the static string identity
    fn as_str(&self) -> &str;
}

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 18, 2022

Having two symbols with the same name in the same workspace that works (more or less) the same is confusing.

@ikrivosheev
Copy link
Member Author

@tyt2y3 @billy1624 @nitnelave I have done. Can you have a look at it?

src/types.rs Outdated Show resolved Hide resolved
@ikrivosheev ikrivosheev merged commit 3972e0b into SeaQL:master Dec 5, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-484_iden_static branch December 5, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Iden with sqlx is cumbersome
4 participants