Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues-398 Refactoring work with function #475

Conversation

ikrivosheev
Copy link
Member

@ikrivosheev ikrivosheev commented Oct 15, 2022

PR Info

Adds

  • SelectStatement::from_function - allow to use SELECT FROM func()
  • impl<T> From<T> for SelectExpr where T: Into<SimpleExpr>
  • impl From<FunctionCall> for SimpleExpr
  • New struct FunctionCall hold function and args for call the function

Breaking Changes

  • Func::* now return FunctionCall insted SimpleExpr
  • Func::coalesce accept IntoIterator<Item = SimpleExpr> instead IntoIterator<Item = Into<SimpleExpr>

Changes

  • Expr::expr accept Into<SimpleExpr> instead SimpleExpr
  • Removed Expr::arg and Expr::args - this functions are unneeded

@ikrivosheev ikrivosheev self-assigned this Oct 15, 2022
@tyt2y3
Copy link
Member

tyt2y3 commented Oct 16, 2022

Looks good at first glance. Seems like a lot of changes. Can we release this later, i.e. 0.28?

@ikrivosheev ikrivosheev merged commit 2b21cc4 into SeaQL:master Nov 2, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-398_refactoring_work_with_function branch November 2, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to select from function
2 participants