Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): Add 'license' definition #4596

Merged
merged 2 commits into from
Dec 26, 2021
Merged

fix(schema): Add 'license' definition #4596

merged 2 commits into from
Dec 26, 2021

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Dec 26, 2021

Description

HOTFIX: Fix AppVeyor error

Motivation and Context

Relates to #4594 (comment)

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@niheaven
Copy link
Member Author

This PR should be synced to 'develop' after merging.

@rashil2000
Copy link
Member

Still failing. See https://github.com/rashil2000/Extras fork, and the run here: https://ci.appveyor.com/project/rashil2000/extras/builds/42008819/job/t5t6l8atgtgbhu8u

Maybe you need to update /test/fixtures/manifest/invalid_wget.json too?

@niheaven
Copy link
Member Author

It's a different failure. I'll check it.

@niheaven
Copy link
Member Author

Tested locally

image

@rashil2000
Copy link
Member

@rashil2000
Copy link
Member

@issaclin32 this one slightly high priority, can you approve it if you're around?

@issaclin32 issaclin32 merged commit 5602083 into master Dec 26, 2021
@issaclin32 issaclin32 deleted the fix-schema branch December 26, 2021 15:01
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
* fix(schema): Add 'license' definition

Fix AppVeyor error

* Fix 'Manifest.Tests'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants