Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'develop' into master #4527

Merged
merged 24 commits into from
Nov 22, 2021
Merged

Merge branch 'develop' into master #4527

merged 24 commits into from
Nov 22, 2021

Conversation

rasa and others added 24 commits March 10, 2020 13:46
Add multiple URLs support to 'autoupdate'

Co-Authored-By: Jakub Čábera <[email protected]>

Signed-off-by: Hsiao-nan Cheung <[email protected]>
Also refactor
- 'update_manifest_with_new_version' -> 'Update-ManifestProperty'
- 'update_manifest_prop' -> 'PropertyHelper'
- 'autoupdate' -> 'Invoke-AutoUpdate'

Co-Authored-By: Jakub Čábera <[email protected]>

Signed-off-by: Hsiao-nan Cheung <[email protected]>
Bash will parse the '*' on the shell level which results in a strange
experience for everyone not familiar with it when trying to update
all packages. This adds -a and --all as alternatives.
Co-authored-by: WorldYun <[email protected]>
Co-authored-by: Hsiao-nan Cheung <[email protected]>
And also trim `\` in `-DestinationPath`
* Add alt-shim support via scoop config shim rshim

* update to new version
Co-authored-by: Jakub Čábera <[email protected]>
Co-authored-by: David Duque <[email protected]>
Add flags as an alternative to '*' to update all
@niheaven niheaven requested a review from a team November 22, 2021 14:01
Copy link
Contributor

@pratikpc pratikpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Develop has been stable enough for me!!

@issaclin32
Copy link
Member

issaclin32 commented Nov 22, 2021

I have been using the develop branch (scoop config branch develop), and haven't encounter a problem so far.

@rashil2000
Copy link
Member

Should we prepare some release notes type of thing?

There have been many changes, it'll be good to document them.

@niheaven
Copy link
Member Author

Emm, there isn't a NEWS.md in this repo, and neither a release circle...

I've added all the changes in PR's content and may add NEWS.md in master after this is merged, and maintained it in develop.

There is a discussion that Scoop Core may have stable release and since I'm not familiar with GitHub's release, may someone else help?

@rashil2000
Copy link
Member

From the tags page (https://github.com/ScoopInstaller/Scoop/tags) I can see there were some releases in the past (albeit without any notes, just tags are there).

We can create a tag from master (after this PR is merged) and create a release from that tag, see:

image

@rasa
Copy link
Member

rasa commented Nov 22, 2021

Works for me! Thanks for all the great work!

@niheaven
Copy link
Member Author

🎉 But, where's the review approval? I cannot merge it without them 😭

@niheaven niheaven merged commit 59088a9 into master Nov 22, 2021
@pratikpc
Copy link
Contributor

@niheaven need to rebase develop now

This branch is 9 commits behind master.

@niheaven
Copy link
Member Author

@niheaven need to rebase develop now

This branch is 9 commits behind master.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.