add image for example load_nemo #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
commented
Sep 17, 2019
| @@ -20,7 +22,7 @@ def create_v4_images_listfile(search_dirpath=V4_DIR, filespec='*.png', | |||
| output_filepath=V4_LISTFILE_PATH): | |||
| file_names = get_v4_imagefile_names(search_dirpath, filespec) | |||
| with open(output_filepath, 'w') as f_out: | |||
| for file_name in file_names: | |||
| for file_name in sorted(file_names): | |||
There was a problem hiding this comment.
Sorting ensures that a newly generated v4_files_listing.txt file is ordered, making PR changes easier to review - otherwise it's not guaranteed that the same v4_files_listing.txt can be recreated.
There was a problem hiding this comment.
This will make things much easier!
|
@lbdreyer Can I tempt you again with this PR? 😉 |
|
A bit hard to review with all the changes to the listing, now that they are being sorted. But hopefully future reviews will be easier now the sort is in place! |
|
@lbdreyer Awesome, thanks! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports Iris PR 3398, which adds the new
load_nemoexample to the gallery.