Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh saveload fix #6004

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+205 −100
Open

Mesh saveload fix #6004

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
802a4f3
Remove obsolete code which saves identical meshes separately.
pp-mo Jun 12, 2024
9ab26dc
Better error messages for mis-configured mesh data variables.
pp-mo Jun 12, 2024
a4dad3a
Add tests for more intelligible errors.
pp-mo Jun 12, 2024
4b06462
Add licence header.
pp-mo Jun 13, 2024
5365ade
Fix test for changes to mesh saving.
pp-mo Jun 13, 2024
e57c30d
Inline method which was used just once, and specific to the use.
pp-mo Jun 13, 2024
993189e
Add whatsnew entry.
pp-mo Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
Remove obsolete code which saves identical meshes separately.
  • Loading branch information
@pp-mo
pp-mo committed Jun 12, 2024
commit 802a4f3b5bffe58c8bed4623fa3a88a9434af9fe
7 changes: 0 additions & 7 deletions lib/iris/fileformats/netcdf/saver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,13 +1216,6 @@ def record_dimension(names_list, dim_name, length, matching_coords=None):
assert len(dim_coords) == 1
dim_element = dim_coords[0]
dim_name = self._dim_names_and_coords.name(dim_element)
if dim_name is not None:
# For mesh-identifying coords, we require the *same*
# coord, not an identical one (i.e. "is" not "==")
stored_coord = self._dim_names_and_coords.coord(dim_name)
if dim_element is not stored_coord:
# This is *not* a proper match after all.
dim_name = None
if dim_name is None:
# No existing dim matches this, so assign a new name
if location == "node":
Expand Down