Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov-action gha with token #5941

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented May 8, 2024

🚀 Pull Request

Description

This pull-request explicitly uses the CODECOV_TOKEN with the codecov-action to upload a test report.

Speculating whether this assists with #5915


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (7c313ff) to head (d16c1f4).
Report is 27 commits behind head on main.

❗ Current head d16c1f4 differs from pull request most recent head 004faac. Consider uploading reports for the commit 004faac to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5941      +/-   ##
==========================================
+ Coverage   89.76%   89.78%   +0.01%     
==========================================
  Files          93       93              
  Lines       22982    23007      +25     
  Branches     5006     5017      +11     
==========================================
+ Hits        20630    20657      +27     
+ Misses       1622     1620       -2     
  Partials      730      730              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle
Copy link
Member Author

bjlittle commented May 8, 2024

Migrating to explicitly using the token successfully uploads the test report i.e., the secrets.CODECOV_TOKEN is valid 👍

However, I noticed that we appear to be uploading 6 test reports instead of 1 😮

image

Hmmm I'll confirm whether the action is uploading all of those files or just the single coverage.xml ...

@bjlittle bjlittle marked this pull request as draft May 8, 2024 10:45
@bjlittle bjlittle force-pushed the gha-codecov-token branch 2 times, most recently from ac8ae24 to d16c1f4 Compare May 8, 2024 11:35
@bjlittle
Copy link
Member Author

bjlittle commented May 8, 2024

Okay, I'm not going to burn any more time on this ...

You can use the file: or files: arguments to the gha, but that doesn't seem to make any difference to the action detecting 6 files.

Using the verbose: flag to the gha doesn't offer up any more information on how many files are actually uploaded to the codecov server, and there's nothing obvious on the codecov server-side to indicate the number of report files uploaded.

The fact that this is "working" seems sufficient ... however, whether this change addresses #5915 is yet to be determined.

@bjlittle bjlittle marked this pull request as ready for review May 8, 2024 12:40
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite your reservations, I'm happy that this is at least going in the right direction.
So let's just see what happens.

@pp-mo pp-mo merged commit 1d064e3 into SciTools:main May 8, 2024
20 checks passed
@bjlittle
Copy link
Member Author

bjlittle commented May 8, 2024

@pp-mo Awesome, thanks 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants