-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codecov-action gha with token #5941
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5941 +/- ##
==========================================
+ Coverage 89.76% 89.78% +0.01%
==========================================
Files 93 93
Lines 22982 23007 +25
Branches 5006 5017 +11
==========================================
+ Hits 20630 20657 +27
+ Misses 1622 1620 -2
Partials 730 730 ☔ View full report in Codecov by Sentry. |
Migrating to explicitly using the token successfully uploads the test report i.e., the However, I noticed that we appear to be uploading 6 test reports instead of 1 😮 Hmmm I'll confirm whether the action is uploading all of those files or just the single |
ac8ae24
to
d16c1f4
Compare
d16c1f4
to
004faac
Compare
Okay, I'm not going to burn any more time on this ... You can use the Using the The fact that this is "working" seems sufficient ... however, whether this change addresses #5915 is yet to be determined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite your reservations, I'm happy that this is at least going in the right direction.
So let's just see what happens.
@pp-mo Awesome, thanks 🍻 |
🚀 Pull Request
Description
This pull-request explicitly uses the
CODECOV_TOKEN
with thecodecov-action
to upload a test report.Speculating whether this assists with #5915
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: