Parallel concatenate #5926
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,13 +45,15 @@ class Concatenate: | |
| cube_list: CubeList | ||
|
|
||
| def setup(self): | ||
| source_cube = realistic_4d_w_everything(lazy=True) | ||
| self.cube_list = CubeList([source_cube]) | ||
| for _ in range(24): | ||
|
Comment on lines
+49
to
+50
There was a problem hiding this comment. The concatenate benchmarks now concatenate 25 cubes, to make the benchmark more realistic but not too time-consuming. There was a problem hiding this comment. I tried this branch with one year of high resolution data ( 12 cubes to concatenate) and I get a decrease in time of about 90 seconds with respect to main branch 👍 There was a problem hiding this comment. Thanks for testing @sloosvel! Do you know what the total time was as well? There was a problem hiding this comment. I get around one minute for the parallel concatenation and two minutes / two minutes and a half for the main branch |
||
| next_cube = self.cube_list[-1].copy() | ||
| first_dim_coord = next_cube.coord(dimensions=0, dim_coords=True) | ||
| first_dim_coord.points = ( | ||
| first_dim_coord.points + np.ptp(first_dim_coord.points) + 1 | ||
| ) | ||
| self.cube_list.append(next_cube) | ||
|
|
||
| def time_concatenate(self): | ||
| _ = self.cube_list.concatenate_cube() | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enabled
lazy=Truebecause it seems more realistic, but the timings are very similar for both cases, maybe because the data is small enough to keep in RAM. Is this change wanted or should I change it back?