Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest migration ruff PT compliance for unit.concatenate #5823

Merged

Conversation

bjlittle
Copy link
Member

🚀 Pull Request

Description

@pp-mo I've updated your changes so that they're ruff check --select PT (flake8-pytest-style) compliant.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@bjlittle bjlittle requested a review from pp-mo March 12, 2024 13:34
@bjlittle bjlittle added Type: Feature Branch Highlight this for a feature branch Feature: pytest labels Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (fa86a4f) to head (a073aac).
Report is 8 commits behind head on FEATURE_pytest_conversion.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           FEATURE_pytest_conversion    #5823   +/-   ##
==========================================================
  Coverage                      89.74%   89.74%           
==========================================================
  Files                             92       92           
  Lines                          22940    22940           
  Branches                        5462     5462           
==========================================================
  Hits                           20588    20588           
  Misses                          1620     1620           
  Partials                         732      732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member

pp-mo commented Mar 12, 2024

A wee bit of a downer, because when I spotted that I'd added the empty parentheses then I explicitly removed them !

But certainly can't argue with the standards + consistency message.

@pp-mo pp-mo merged commit d807650 into SciTools:FEATURE_pytest_conversion Mar 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: pytest Type: Feature Branch Highlight this for a feature branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants