Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ncdata and CF information on "iris heart xarray" page #5752

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Feb 16, 2024

Addresses #5517

@pp-mo pp-mo changed the title Introduce ncdata; more info on Xarray CF handling. Improve ncdata and CF information on "iris heart xarray" page Feb 16, 2024
@pp-mo pp-mo linked an issue Feb 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a47fd34) 89.71% compared to head (142266e) 89.74%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5752      +/-   ##
==========================================
+ Coverage   89.71%   89.74%   +0.02%     
==========================================
  Files          90       91       +1     
  Lines       22815    22925     +110     
  Branches     5438     5462      +24     
==========================================
+ Hits        20468    20573     +105     
- Misses       1617     1620       +3     
- Partials      730      732       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephenworsley stephenworsley self-assigned this Feb 16, 2024
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple minor things, I think there are also other places within this page which use single `s where they could use double ``s which would be good to also change for the sake of cosistency.

docs/src/community/iris_xarray.rst Outdated Show resolved Hide resolved
docs/src/community/iris_xarray.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephenworsley stephenworsley merged commit e5c2c0c into SciTools:main Feb 19, 2024
17 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Feb 20, 2024
…umpydoc-pre-commit

* 'numpydoc-pre-commit' of github.com:tkknight/iris:
  Update CF standard names to v84. (SciTools#5761)
  Regrid docs fix (SciTools#5758)
  Improve ncdata and CF information on "iris heart xarray" page (SciTools#5752)
  Pin ASV - airspeed-velocity/asv#1385. (SciTools#5756)
  Normalise units of coordinate bounds (SciTools#5746)
  Add "Which Regridder?" Documentation (SciTools#5742)
  Document `Coord.ignore_axis` (SciTools#5744)
  Disable navidation with keys for docs HTML theme options (SciTools#5747)
  Shapefile masking (SciTools#5470)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5739)
  DOCS: Add whatsnew for ruff pydocstyle compliance (SciTools#5700)
  update docstring (SciTools#5737)
  Updated environment lockfiles (SciTools#5738)
  Consider NaNs equal when comparing cubes (SciTools#5713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Add Xarray bridge documentation referencing ncdata
2 participants