Fix Flake8 E721 errors
#5408
Merged
Fix Flake8 E721 errors
#5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## pre-commit-ci-update-config #5408 +/- ##
============================================================
Coverage 89.37% 89.37%
============================================================
Files 89 89
Lines 22440 22440
Branches 5380 5380
============================================================
Hits 20055 20055
Misses 1639 1639
Partials 746 746
☔ View full report in Codecov by Sentry. |
bjlittle
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Awesome, nice one! Thanks @trexfeathers
We should also look into using https://github.com/asottile/pyupgrade to catch these sort of syntax changes.
bjlittle
merged commit 71665aa
into
SciTools:pre-commit-ci-update-config
17 checks passed
trexfeathers
added a commit
that referenced
this pull request
Aug 1, 2023
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/PyCQA/flake8: 6.0.0 → 6.1.0](PyCQA/flake8@6.0.0...6.1.0) * Switch to isinstance(). (#5408) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Martin Yeo <[email protected]>
|
Thanks @bjlittle! Iris is now Flake8 6.1 compliant 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Fixes to avoid
E721in #5406.Consult Iris pull request check list