Avoid using deprecated ContourSet attributes #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5405 +/- ##
==========================================
- Coverage 89.37% 89.37% -0.01%
==========================================
Files 89 89
Lines 22426 22444 +18
Branches 5379 5382 +3
==========================================
+ Hits 20043 20059 +16
- Misses 1637 1639 +2
Partials 746 746
☔ View full report in Codecov by Sentry. |
trexfeathers
approved these changes
Jul 31, 2023
|
Thanks @trexfeathers that was quick! 🚀 |
acchamber
added a commit
to acchamber/iris
that referenced
this pull request
Aug 7, 2023
…o fix_for_#5372 * 'fix_for_#5372' of https://github.com/acchamber/iris: [pre-commit.ci] pre-commit autoupdate (SciTools#5406) Avoid using deprecated ContourSet attributes (SciTools#5405) removed redundant timeattr check and added tests to ensure datetime/c… (SciTools#5396) Include location coordinates in the data variable coordinates attribute (SciTools#5389) Added link to UDUNITS-2 database to convert_units docstrings (SciTools#5388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
For Matplotlib v3.8 the
ContourSetclass had a re-write (matplotlib/matplotlib#25247) and various of its attributes will be deprecated in the upcoming release. Relevant release notes arehttps://matplotlib.org/devdocs/api/next_api_changes/deprecations/25138-AL.html
https://matplotlib.org/devdocs/api/next_api_changes/deprecations/25247-AL.html
https://matplotlib.org/devdocs/api/next_api_changes/deprecations/26399-REC.html
iplt.contourfuses some of these attributes so this PR updates it to work with the newContourSet.Consult Iris pull request check list