Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge support #5216

Closed
wants to merge 7 commits into from
Closed

Bridge support #5216

wants to merge 7 commits into from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Mar 27, 2023

NOT FOR MERGE

A preliminary attempt at combining #5212 and #5214, rebased onto recent main branch, for testing "bridge" code
( as in #4994 ).

N.B. 2f4751d indicates that we may have a bit more work to successfully integrate these changes with those from #5095 .

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 90.42% and project coverage change: +0.04 🎉

Comparison is base (7dfc29a) 89.27% compared to head (2f4751d) 89.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5216      +/-   ##
==========================================
+ Coverage   89.27%   89.31%   +0.04%     
==========================================
  Files          88       88              
  Lines       22258    22284      +26     
  Branches     4867     4877      +10     
==========================================
+ Hits        19871    19904      +33     
+ Misses       1641     1637       -4     
+ Partials      746      743       -3     
Impacted Files Coverage Δ
lib/iris/fileformats/netcdf/saver.py 89.97% <81.81%> (+0.05%) ⬆️
lib/iris/__init__.py 88.88% <83.33%> (+0.36%) ⬆️
lib/iris/fileformats/__init__.py 84.37% <100.00%> (-0.48%) ⬇️
lib/iris/fileformats/cf.py 85.65% <100.00%> (+0.11%) ⬆️
lib/iris/fileformats/netcdf/loader.py 80.29% <100.00%> (+0.29%) ⬆️
lib/iris/io/__init__.py 82.97% <100.00%> (+2.09%) ⬆️
lib/iris/io/format_picker.py 83.72% <100.00%> (+2.26%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pp-mo pp-mo added the Type: Feature Branch Highlight this for a feature branch label Mar 27, 2023
@pp-mo
Copy link
Member Author

pp-mo commented Jun 27, 2023

No longer needed -- the required support is now in 'main'

@pp-mo pp-mo closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Branch Highlight this for a feature branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant