-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing typo's in Gitwash. #5145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome aboard @HGWright 🥳
This PR looks good to me. Thanks for your first (of many 😉) contribution to iris
!
I think that it's totally appropriate for you to add an entry to the whatsnew
latest.rst. In particular,
- to the Announcements section, highlighting that this is your first contribution (see the first entry here in the
iris
v3.4.0 releasewhatsnew
, as an example) - to the Documentation section, detailing your change. Simply follow the style guide and format of other existing entries
Lookin' forward to banking this PR 😄
@HGWright As you aren't an
If you don't do this, then you'll find that your user name is a broken link. Confirm this is the case by building the docs and viewing the |
That's my bad @bjlittle! @HGWright asked me and I encouraged him to put the link into |
No worries, all good. Yup, my eye glazed over that entry. I'm happy if you are. All good 😄 |
@HGWright Nice one! 🥳 |
* upstream/main: (23 commits) Lockfiles and pydata-sphinx-theme fix (SciTools#5188) Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation (SciTools#5084) removed cell measure mask check and error (SciTools#5181) Updated environment lockfiles (SciTools#5177) Lazy weighted RMS calculation (SciTools#5017) Add coverage badge to README.md (SciTools#5176) Add coverage testing (SciTools#4765) Whats new updates for v3.4.1 . NetCDF thread safety take two (SciTools#5095) Updated environment lockfiles (SciTools#5163) Plugin support (SciTools#5144) Expand scope of common contributor links (SciTools#5159) Replace apparently retired UDUNITS documentation link. (SciTools#5153) [pre-commit.ci] pre-commit autoupdate (SciTools#5150) Fixing typo's in Gitwash. (SciTools#5145) add readme #showyourstripes (SciTools#5141) [pre-commit.ci] pre-commit autoupdate (SciTools#5143) Iris ❤ Xarray docs page. (SciTools#5025) [pre-commit.ci] pre-commit autoupdate (SciTools#5136) Updated citation (SciTools#5116) ...
🚀 Pull Request
Consult Iris pull request check list