Improve Coord and Cube attributes printout #4528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development of #4499, and discussion in #4501, it was suggested that when printing cube components with names/units/attributes (i.e. derived from CFVariableMixin) we should be listing any attributes in a one-per-line fashion, as
Cube.__str__
already does.This wasn't initially done in #4499 as I was concerned it introduced more change to an already complex PR.
On subsequent investigation though, it isn't really that complex, so this PR introduces that.
Results go from looking (schematically) like
to
Comparing the output of attributes in Cube listings to those in Coords, I also came to the conclusion that it would be better to always quote strings when they appear as attribute values -- that is, in Cube listings also.
Luckily that is very easy to do -- though there were quite a few tests to fix, so it's a bit noisy.