Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetCDF save - stream ALL lazy arrays. #4375

Merged
merged 9 commits into from
Oct 20, 2021
Merged

NetCDF save - stream ALL lazy arrays. #4375

merged 9 commits into from
Oct 20, 2021

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Modifications to the NetCDF saving code to allow all data arrays (e.g. Coord.points) to be streamed if they are lazy.

Consult Iris pull request check list

@trexfeathers trexfeathers mentioned this pull request Oct 14, 2021
Closed
pp-mo
pp-mo reviewed Oct 18, 2021
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an initial suggestion

lib/iris/fileformats/netcdf.py Outdated Show resolved Hide resolved
pp-mo
pp-mo reviewed Oct 19, 2021
View reviewed changes
lib/iris/util.py Outdated Show resolved Hide resolved
pp-mo
pp-mo approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tidy code : much less fuss than I imagined !
( + I know it took a lot of thinking out )
All comments now addressed.

@pp-mo pp-mo merged commit ea4434e into SciTools:main Oct 20, 2021
tkknight added a commit to tkknight/iris that referenced this pull request Nov 3, 2021
@tkknight
Merge branch 'main' into theme_play
af1112d 
* main: (44 commits)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4395)
  min pin for numpy (nep29) (SciTools#4386)
  Updated environment lockfiles (SciTools#4393)
  Extend stock.mesh api (SciTools#4389)
  Updated environment lockfiles (SciTools#4388)
  Integrate ASV with Nox (SciTools#4378)
  NetCDF save - stream ALL lazy arrays. (SciTools#4375)
  adopt flake8 maccabe complexity metric (SciTools#4380)
  Accept inverse_flattening = 0 for spherical ellipsoid (closes SciTools#4146) (SciTools#4368)
  Updated environment lockfiles (SciTools#4379)
  Prevent warning in `test_Saver` (SciTools#4376)
  drop pyugrid in site.cfg (SciTools#4373)
  `flake8` dependency (SciTools#4371)
  update latest whosnew (SciTools#4372)
  Allow `check_graphic` to be more flexible (SciTools#4370)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4365)
  Updated environment lockfiles (SciTools#4364)
  Update latest.rst (SciTools#4362)
  More clarity on setting `iris-test-data` location. (SciTools#4359)
  update whatsnew (SciTools#4361)
  ...
@pp-mo pp-mo mentioned this pull request Nov 3, 2021
Merged
@trexfeathers trexfeathers mentioned this pull request Mar 1, 2022
Closed
@trexfeathers trexfeathers deleted the AVD-1867_lazy_saving branch March 31, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees
No one assigned
Labels
Experience: Medium Feature: UGRID Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trexfeathers @pp-mo