Cubelist extract strict #3715
Merged
Cubelist extract strict #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
force-pushed
the
cubelist_extract_strict
branch
from
e784b39
to
f2a28bb
Compare
pp-mo
force-pushed
the
cubelist_extract_strict
branch
from
c3d013b
to
2b4a70b
Compare
|
I don't understand why it's just stopped testing in Travis. |
trexfeathers
requested changes
May 22, 2020
There was a problem hiding this comment.
Very nice work @pp-mo, especially with the Mixins! Just a couple of minor points for you to look at, but overall it seems pretty water-tight.
Regarding Travis: I pushed a copy of this PR up to my own fork and Travis gave the latest commits a full pass so no problems there 👍
|
Everything has passed, LGTM, thanks @pp-mo |
trexfeathers
approved these changes
May 27, 2020
tkknight
pushed a commit
to tkknight/iris
that referenced
this pull request
Jun 29, 2020
* Allow iterable of constraints. * Add new cubelist extract methods, and tests. * Remove old 'strict' cubelist extraction; add whatsnew. * Tidy private routine interface, and replace use in unrelated test. * Pointless tweak to re-try Travis. * Review change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "cubelist.extract(..., strict=True)" and the equivalent "cubelist.extract_strict(...)" with a newer-style API.
Closes #3695
As noted there, this is more in keeping with other facilities, and also addresses the slightly quirky return-type behaviour of the old style : The old method would return a cubelist for 0 or 2..N constraints/results, but just a cube for exactly one constraint.