Fix cube-arith possible problem in 'pearsonr'. #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the concern which is the last remaining unticked todo in #3554.
We are currently still uncertain what the exact behaviour of cube arithmetic will be in Iris 3.0.
In the absence of #3478, we have currently enabled
cube.copy()to replicate cell measures, which means that certain operations no longer discard cell measures (or ancillaries).This creates possible problems for some existing user code, and some internal code including this
pearsonrroutine.In principle, #3618 will also fix this problem, but we may yet choose #3478 over that and we're not yet sure exactly what that will do.
So this change is a definite resolution of this small problem, irrespective of what we eventually choose to do about cube arithmetic generally.