Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI-3524: Update iris colour logo #3599

Merged
merged 3 commits into from
Dec 16, 2019
Merged

Conversation

abooton
Copy link
Contributor

@abooton abooton commented Dec 15, 2019

No description provided.

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@pp-mo
Copy link
Member

pp-mo commented Dec 16, 2019

I note that the new pics still don't have the natural "centre" of the design (middle of the petals) at the exact centre of the image.

Adding halfway lines to the 100-size gets you this ...
Iris7_1_trim_100_withquarters

But it is now close + I think looks probably ok.
Was this as intended ?

@abooton abooton changed the base branch from master to v2.3.x December 16, 2019 11:43
@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@abooton
Copy link
Contributor Author

abooton commented Dec 16, 2019

I note that the new pics still don't have the natural "centre" of the design (middle of the petals) at the exact centre of the image.

Adding halfway lines to the 100-size gets you this ...
Iris7_1_trim_100_withquarters

But it is now close + I think looks probably ok.
Was this as intended ?

I cropped the canvas to the edge of the picture. Maybe I should have cropped it so that it is to the edge of the maximum radius of the petals ?

@pp-mo
Copy link
Member

pp-mo commented Dec 16, 2019

Maybe I should have cropped it so that it is to the edge of the maximum radius of the petals ?

That sounds right.
Is it easy to do ??

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@abooton
Copy link
Contributor Author

abooton commented Dec 16, 2019

The current logo files are all cropped at the edge of the image, and the backgrounds are all transparent.
The size of the current logos has been replicated wrt the height of the images, but the new width of the logo is slightly different, hence the image sizes will differ.
I've added a "iris_colour_logo_centred.png" image. This has the centre of the iris in the centre of the image, so can be used for twitter.

@pp-mo pp-mo merged commit c99ffe4 into SciTools:v2.3.x Dec 16, 2019
@abooton abooton changed the title Update iris colour logo Pi-3524: Update iris colour logo Dec 17, 2019
@abooton abooton changed the title Pi-3524: Update iris colour logo PI-3524: Update iris colour logo Dec 17, 2019
@bjlittle bjlittle mentioned this pull request Dec 17, 2019
3 tasks
@abooton abooton added this to the v3.0.0 milestone Dec 19, 2019
@abooton abooton added this to In Progress in Iris v3.0.0 via automation Dec 19, 2019
@pp-mo pp-mo moved this from In Progress to Done in Iris v3.0.0 Dec 19, 2019
pp-mo pushed a commit to pp-mo/iris that referenced this pull request Dec 20, 2019
pp-mo pushed a commit to pp-mo/iris that referenced this pull request Dec 20, 2019
tkknight pushed a commit to tkknight/iris that referenced this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Iris v3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants