-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simpler License Headers #3489
Simpler License Headers #3489
Conversation
… Iris Contributors
…hecking license years.
…ed for checking license years." This reverts commit 1276b72.
… at the start of the file.
…es not have the header.
Apologies for the slightly messy commit sequence - was originally just aiming for changing the years |
Not sure how GitHub should be detecting the license, since LICENSE is supposed to be the name and COPYING.LESSER was an unconventional alternative |
This is incorrect. The |
@trexfeathers For some context, see How to use GNU licenses for your own software... That said, at the moment I'd suggest that When, and if, we move to a |
docs/iris/example_tests/__init__.py
Outdated
@@ -1,19 +1,7 @@ | |||
# (C) British Crown Copyright 2010 - 2015, Met Office | |||
# Copyright Iris Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Copyright Iris contributors
not # Copyright Iris Contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
docs/iris/src/conf.py
Outdated
@@ -100,7 +88,7 @@ | |||
# define the copyright information for latex builds. Note, for html builds, | |||
# the copyright exists directly inside "_templates/layout.html" | |||
upper_copy_year = datetime.datetime.now().year | |||
copyright = u'British Crown Copyright 2010 - {}, Met Office'.format(upper_copy_year) | |||
copyright = u'Copyright Iris Contributors' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright Iris contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
docs/iris/src/copyright.rst
Outdated
but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU Lesser General Public License for more details. | ||
Copyright Iris Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
LICENSE_TEMPLATE = \ | ||
"""# Copyright Iris Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@trexfeathers Awesome, many thanks! 👍 |
Addresses #3285.
In line with the latest SciTools licensing guidelines, the license headers are much shorter and mostly reference the master file in the root directory.
Also in line with these guidelines, the COPYING.LESSER file has been refactored to be called LICENSE, while COPYING has been removed since it was not being referenced.
The years test in test_coding_standards.py has been replaced with a basic check that each file starts with the correct string.