Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cube HTML repr CSS improvements #3380

Closed
wants to merge 3 commits into from

Conversation

DPeterK
Copy link
Member

@DPeterK DPeterK commented Aug 27, 2019

Use CSS variables defined in Jupyterlab for styling custom elements of the cube repr table. The primary advantage of doing this is that the cube html repr table will correctly follow different Jupyterlab themes:

Light theme:
Screenshot 2019-08-27 at 12 00 58
Dark theme:
Screenshot 2019-08-27 at 12 00 40

Also removed max-width attribute of table columns.

@stephenworsley
Copy link
Contributor

stephenworsley commented Sep 25, 2019

If I understand correctly, this would make the _html_repr_ better integrated into Jupyter but would make the _html_repr_ less well integrated into other environments without access to --jp-* css variables. Is there anywhere other than Jupyter where we could reasonably expect _html_repr_ to be used?

@bjlittle bjlittle self-assigned this Oct 2, 2019
@bjlittle bjlittle added this to the v3.0.0 milestone Oct 3, 2019
@DPeterK
Copy link
Member Author

DPeterK commented Dec 3, 2019

@stephenworsley correct, this is explicitly targetting Jupyter environments, which is the only place that _repr_html_ could conceivably be called on a Python object, as it's part of the broader Jupyter API. I'm pretty sure this means that alternate notebook environments, such as nteract, won't be impacted by this change.

@DPeterK
Copy link
Member Author

DPeterK commented Dec 3, 2019

Rebase...

@jamesp jamesp added this to the v3.3.0 milestone Oct 28, 2021
@trexfeathers
Copy link
Contributor

This seems to have gone stale. We still have ambitions for better HTML, particularly given @pp-mo's work turning the Cube summary into actual objects, which would make for much better HTML creation. But that would need a different PR, so I'm going to close this one. @DPeterK feel free to re-open if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants