Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dress naked excepts #2 #3369

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Aug 20, 2019

Replaces #3366,
just so we can resolve in @bjlittle absence

Original head

This PR fixes the iris travis-ci tests after moving to the latest numpy 1.17.0 - and it also follows-up from #3320 to dress the naked try...excepts with an ImportError

Closes #3365 (ref old comment)

@pp-mo pp-mo mentioned this pull request Aug 20, 2019
@rcomer rcomer self-assigned this Aug 20, 2019
@rcomer
Copy link
Member

rcomer commented Aug 20, 2019

Looks good to me. Just waiting for Travis to do its thing...

@rcomer rcomer merged commit d0213d8 into SciTools:master Aug 20, 2019
@pp-mo
Copy link
Member Author

pp-mo commented Aug 20, 2019

Many thanks again @rcomer !

@pp-mo pp-mo mentioned this pull request Aug 20, 2019
@QuLogic QuLogic added this to the v2.3.0 milestone Aug 24, 2019
@pp-mo pp-mo deleted the dress-naked-excepts-ppmo branch March 18, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ifunc, inspect and numpy 1.17
4 participants