Add dask to install docs. #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdreyer
commented
Jul 4, 2017
INSTALL
Outdated
| @@ -86,6 +86,9 @@ scipy 0.10 or later (http:https://www.scipy.org/) | |||
| cartopy 0.11.0 or later (http:https://github.com/SciTools/cartopy/) | |||
| Python package which provides cartographic tools for python. | |||
|
|
|||
| dask 0.11.0 or later (https://dask.pydata.org/) | |||
There was a problem hiding this comment.
I have specified 0.11.0 because we use dask.array.absolute which was only included in 0.11.0
Note also the workaround for < and > dask 0.15 (see here)
I do find it concerning that we are using dask which hasn't released a major version (i.e. dask 1.0.0) yet
There was a problem hiding this comment.
Sure. The same could be said of cartopy though... 😉
There was a problem hiding this comment.
Why not just go for dask > 0.15? I don't see any advantage of supporting a legacy version.
pelson
approved these changes
Jul 4, 2017
marqh
pushed a commit
to marqh/iris
that referenced
this pull request
Jul 14, 2017
Add dask to 'INSTALL'; require dask>=0.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2613