Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch setting of coordiantes and bounds for netcdf saver (string typing) #2179

Merged
merged 7 commits into from
Oct 10, 2016

Conversation

marqh
Copy link
Member

@marqh marqh commented Oct 10, 2016

fix to make #2158 functional for newer netcdf4-python

i am not convinced this catch all potential cases, only the ones we test

a few words prior to merge would be helpful

@pelson
Copy link
Member

pelson commented Oct 10, 2016

Does cf_var_grid.grid_mapping_name need to be considered?

Copy link
Member

@pelson pelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge at will. 👍

cartopy
matplotlib=1.3.1
matplotlib
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mpl pin should not be changed in this PR

@pelson
Copy link
Member

pelson commented Oct 10, 2016

Python3 issue with your unit test:

======================================================================
FAIL: test_spherical_geog_cs (iris.tests.unit.fileformats.netcdf.test_Saver.Test__create_cf_grid_mapping)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/test-environment/lib/python3.4/site-packages/Iris-1.11.0.dev0-py3.4-linux-x86_64.egg/iris/tests/unit/fileformats/netcdf/test_Saver.py", line 570, in test_spherical_geog_cs
    self._test(coord_system, expected)
  File "/home/travis/miniconda/envs/test-environment/lib/python3.4/site-packages/Iris-1.11.0.dev0-py3.4-linux-x86_64.egg/iris/tests/unit/fileformats/netcdf/test_Saver.py", line 546, in _test
    actual = self._variable_attributes(coord_system)
  File "/home/travis/miniconda/envs/test-environment/lib/python3.4/site-packages/Iris-1.11.0.dev0-py3.4-linux-x86_64.egg/iris/tests/unit/fileformats/netcdf/test_Saver.py", line 537, in _variable_attributes
    mock_grid_variable = self._grid_mapping_variable(coord_system)
  File "/home/travis/miniconda/envs/test-environment/lib/python3.4/site-packages/Iris-1.11.0.dev0-py3.4-linux-x86_64.egg/iris/tests/unit/fileformats/netcdf/test_Saver.py", line 528, in _grid_mapping_variable
    grid_variable.grid_mapping_name)
AssertionError: b'latitude_longitude' != 'latitude_longitude'
----------------------------------------------------------------------

@pelson pelson merged commit 394f028 into SciTools:master Oct 10, 2016
@pelson
Copy link
Member

pelson commented Oct 10, 2016

👍

@QuLogic QuLogic added this to the v1.11 milestone Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants