Fixed aggregate_by bug for single values coordinates. #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| result = cube.aggregated_by('foo', MEAN) | ||
| self.assertEqual(result.shape, (2, 4)) | ||
| self.assertEqual(result.coord('bar'), | ||
| AuxCoord(['a|a', 'a|a'], long_name='bar')) |
There was a problem hiding this comment.
This doesn't look right to me. I'd have thought you'd get
AuxCoord(['a|a', 'a'], long_name='bar')There was a problem hiding this comment.
Nope, I'm always using the two bounds from the slice, even if they are the same thing.
I believe this to be consistent with the existing behaviour (when it doesn't break) - I was tempted to try making this better (and did start doing so) but it wasn't as trivial a fix. If you want me to though, I'd happily look into the prospect of only joining if there is more than one value.
|
Closing this PR - I'll take @esc24's suggestion on board an make a new PR targeting v1.7.x. |
This was referenced Jun 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1183.