-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quickplot should provide a show method #607
Comments
+1 - I've come up against this as well |
Just for completeness, quickplot does include a reference to matplotlib's pyplot module (which hosts the |
Yeah I suppose so, but I'm wary about encouraging I still think it would be nice for quickplot to have its own show, making it consistent with the standard matplotlib interface and the |
+1 |
😱 I was just playing devil's advocate with my previous post, but I didn't realise how devilish it could get! My personal opinion is we shouldn't encourage things like I know I'm going off on a tangent somewhat, but this is a general issue. Most imports are implementation detail. As such it'd be more consistent if they were prefixed with an underscore, e.g. |
You are absolutely right the imports are implementation details, but there are going to be a lot of underscores if you treat them that way! As long as you provide an adequate public interface that doesn't encourage this type of bad behaviour I don't think there is a problem. |
Indeed. The explosion of underscores might be why you don't see this idiom elsewhere. For now I'm just going to let the idea lurk in the back of my mind. But once it occurred to me I felt I ought to share. 😉 Anyway ... enough of tangents ...
|
Add show to quickplot. Closes #607.
Currently
iris.plot
provides a convenienceshow()
method butiris.quickplot
does not. This means that users making quickplot plots are forced to load another module in order to display them. A convenienceshow()
method should be added toiris.quickplot
also.The text was updated successfully, but these errors were encountered: