Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh saveload fix #6004

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Mesh saveload fix #6004

wants to merge 6 commits into from

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jun 12, 2024

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@pp-mo pp-mo linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.72%. Comparing base (e92e36a) to head (e57c30d).

Files Patch % Lines
lib/iris/experimental/ugrid/load.py 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6004      +/-   ##
==========================================
- Coverage   89.75%   89.72%   -0.04%     
==========================================
  Files          90       90              
  Lines       22929    22935       +6     
  Branches     5020     5021       +1     
==========================================
- Hits        20580    20578       -2     
- Misses       1618     1626       +8     
  Partials      731      731              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member Author

pp-mo commented Jun 13, 2024

Hi @ESadek-MO
I fixed the test problems + I think this is probably good to review now.
Let me know what you think !

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pp-mo! Looks good to me, just need a whatsnew then happy for this to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Rationalising mesh dimension names
2 participants