Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci_wheels running "publish to test.pypi" on local-fork/main #5180

Closed
ESadek-MO opened this issue Feb 27, 2023 · 1 comment · Fixed by #5220
Closed

ci_wheels running "publish to test.pypi" on local-fork/main #5180

ESadek-MO opened this issue Feb 27, 2023 · 1 comment · Fixed by #5220
Labels
Good First Issue A good issue to take on if you're just getting started with Iris development Type: Bug

Comments

@ESadek-MO
Copy link
Contributor

🐛 Bug Report

When pushing up to <local-fork>/main, the "publish to test.pypi" test is attempted, which inevitably fails.
It would be good to limit this to only run on the SciTools repo, to avoid the extra hassle.
@lbdreyer
Copy link
Member

It presumably just needs aif: "github.repository_owner == 'SciTools'" check in the publish_* jobs? We do this with the refresh-lockfiles action (e.g. https://github.com/SciTools/workflows/blob/main/.github/workflows/refresh-lockfiles.yml#L25)

@trexfeathers trexfeathers added the Good First Issue A good issue to take on if you're just getting started with Iris development label Feb 27, 2023
agriyakhetarpal added a commit to agriyakhetarpal/iris that referenced this issue Mar 29, 2023
@agriyakhetarpal
SciTools#5180 do not run publish-to-test-pypi on forks
73d7c9c
@agriyakhetarpal agriyakhetarpal mentioned this issue Mar 29, 2023
Merged
lbdreyer added a commit that referenced this issue Mar 30, 2023
@agriyakhetarpal @lbdreyer
#5180 do not run publish-to-test-pypi on forks (#5220)
164484e 
* #5180 do not run publish-to-test-pypi on forks

* do not run "publish to pypi" on forks

* Add what's new for #5220

---------

Co-authored-by: lbdreyer <[email protected]>
HGWright added a commit to HGWright/iris that referenced this issue Apr 3, 2023
@HGWright
Merge branch 'main' of github.com:SciTools/iris into cf_cell_method
8e47e93 
* 'main' of github.com:SciTools/iris:
  Benchmark runner script (SciTools#5215)
  add locks readme (SciTools#5222)
  use explicit version for ci refresh-lockfiles gha (SciTools#5221)
  SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220)
  Fix Makefile for consequences of SciTools#5204. (SciTools#5217)
tkknight added a commit to tkknight/iris that referenced this issue Apr 4, 2023
@tkknight
Merge remote-tracking branch 'upstream/main' into apidoc
1e79eea 
* upstream/main: (274 commits)
  Cf cell method (SciTools#5224)
  Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5230)
  Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227)
  raise dask min pin (SciTools#5225)
  Enable lazy computation of wind vector rotation (SciTools#4972)
  Benchmark runner script (SciTools#5215)
  add locks readme (SciTools#5222)
  use explicit version for ci refresh-lockfiles gha (SciTools#5221)
  SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220)
  Fix Makefile for consequences of SciTools#5204. (SciTools#5217)
  Bump actions/stale from 7 to 8 (SciTools#5208)
  Remove Iris' TestRunner (SciTools#5205)
  standardize requirements structure (SciTools#5204)
  Updated environment lockfiles (SciTools#5199)
  Add histogram convenience for passing Iris objects to plt.hist (SciTools#5189)
  Updated environment lockfiles (SciTools#5192)
  announce new contributor in whatsnew (SciTools#5198)
  iris.util.new_axis anonymous new dimension fix (SciTools#5194)
  Lockfiles and pydata-sphinx-theme fix (SciTools#5188)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue A good issue to take on if you're just getting started with Iris development Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#5180 do not run publish-to-test-pypi on forks agriyakhetarpal/iris
3 participants
@lbdreyer @trexfeathers @ESadek-MO