-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental equalise_cubes #3528
Comments
Closes #3342 |
Now, when this function becomes a 'regular member of iris', would it be possible to have it returning the attributes ( etc) that had to be removed to equalise the cubes? |
Hey @larsbarring, Good to hear from you. I'm assuming that this is because you want to reattach some of the metadata that was removed? |
Yes, either reattaching as for example with tracking_id, or just to know what is not consistent when I expected it to be. |
... and a follow-up thought: A practical example would be a list of cubes having their own unique In this example I might get away without having the tracking_id:s sorted according to concatenation order. But if we take the attribute Admittedly, this should probably be a different issue, but it gives the context for my request above. |
Thanks @larsbarring, much appreciated. My head is in the space of considering how to make You should probably also be aware of #3325 which intends to address the issue of Anyways, I appreciated the unnecessary hoops that users are forced to jump through, so your use case here is valuable, thanks for taking the time to feedback 😃 |
…#4357) * Change equalise_attributes to optionally return deleted attributes (#3528) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added entries in whatsnew/latest.rst * add unit test with minor fixes Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bill Little <[email protected]>
I don’t think this should have been closed by #4357, as we still need to remove the module from |
Follow-up on #3527, and remove the
iris.experimental.equalise_cubes
module, akin to #3523.Target this for the
3.1.0
release.The text was updated successfully, but these errors were encountered: