Remove in-house long time interval checking. #279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #274. Removes cf-units' own checking for long time intervals that might prevent certain operations.
This was introduced in #72, but cftime (previously netcdftime) continues to improve handling of long time intervals, and has a more informative error when they can't be handled. This makes our own checking superfluous and also overzealous.
I have removed all tests concerning long time interval errors, since it would be inappropriate for our tests to depend on the behaviour of cftime.
If this change is accepted: a sister PR on Iris will also be needed, since Iris includes some defensive coding to avoid failure when printing an invalid time
Unit
-iris.coords#L346
. To allow for cftime's continuing improvements - including tolerance for previously invalid time spacings - it would be safest to use try-except during the printing rather than a more specific check.Demonstration