Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Set default zorder for LAND and OCEAN #916

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

dopplershift
Copy link
Contributor

This should help keep them behind most plot elements by default. This
fixes a problem where wind barbs end up hidden by these features.

@QuLogic
Copy link
Member

QuLogic commented Aug 9, 2017

Re-trigger Travis?

@QuLogic QuLogic closed this Aug 9, 2017
@QuLogic QuLogic reopened this Aug 9, 2017
@dopplershift
Copy link
Contributor Author

Travis failure is complaining about libgfortran. Can someone try restarting it?

@QuLogic
Copy link
Member

QuLogic commented Aug 15, 2017

Didn't work; did conda-forge drop support for 3.4?

@dopplershift
Copy link
Contributor Author

dopplershift commented Aug 15, 2017

That sounds familiar...though the packages that were there should still be there.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 16, 2017

That sounds familiar...though the packages that were there should still be there.

And that is exactly the problem. The remaining packages never got updated to defaults latest libgfortran and they are expecting an old one that probably was not pinned down at the time they were built.

I can re-build the stack for cartopy on Python 3.4 if that is really important here. If not, I recommend to just drop Python 3.4 from the tests.

@ajdawson
Copy link
Member

Yeah we should probably just be testing 3.5 and 3.6 and drop 3.4 as @ocefpaf says

@dopplershift
Copy link
Contributor Author

I can change 3.4 -> 3.5 and 3.5 ("latest everything") to 3.6 in .travis.yml. Does that need to be a separate PR?

@ajdawson
Copy link
Member

Well, probably. It may be useful to establish that changing the test setup doesn't break anything independently from the changes here.

@dopplershift
Copy link
Contributor Author

Done in #926.

@ajdawson
Copy link
Member

Can you rebase this please @dopplershift

This should help keep them behind most plot elements by default. This
fixes a problem where wind barbs end up hidden by these features.
@dopplershift
Copy link
Contributor Author

Done.

@ajdawson ajdawson merged commit 988dedc into SciTools:master Dec 13, 2017
@ajdawson
Copy link
Member

Thanks @dopplershift

@dopplershift dopplershift deleted the feature-zorder branch December 13, 2017 21:23
@QuLogic QuLogic added this to the 0.16 milestone Dec 24, 2017
pelson added a commit to pelson/cartopy that referenced this pull request Feb 21, 2018
pelson added a commit to pelson/cartopy that referenced this pull request Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants