Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update other version numbers . #850

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Conversation

lbdreyer
Copy link
Member

@lbdreyer lbdreyer commented Feb 2, 2017

Found a couple other version numbers that also need updating

@bjlittle bjlittle self-assigned this Feb 2, 2017
setup.py Outdated
@@ -335,7 +335,7 @@ def get_config_var(name):
# ==========
setup(
name='Cartopy',
version='0.14.4.dev0',
version='0.15.0',
Copy link
Member

@bjlittle bjlittle Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbdreyer Totally not your doing btw, but it seems a little crazy to me that devs need to remember to do this on release in several places ...

The cartopy.__version__ should suffice here. It's completely discoverable.

If you were to implement a scheme similar to iris, see here and here ...

Then I think this approach might be a step forward in the right direction, and perhaps prevent any future mishaps .. what do you think? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I will add the Iris approach.

Unfortunately this doesn't get around the issue of having to update the version switcher

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbdreyer What if the version_switch.js was to read a json file in order to initialise the all_versions ?

The json file could be generated as part of make html or thought some other mechanism?

Perhaps not part of this PR, but I'll raise an issue to that this isn't forgotten.

@QuLogic QuLogic added this to the 0.15 milestone Feb 2, 2017
@bjlittle
Copy link
Member

bjlittle commented Feb 3, 2017

@lbdreyer Great thanks! 👍

@bjlittle bjlittle merged commit d80e5df into SciTools:master Feb 3, 2017
@QuLogic QuLogic modified the milestones: 0.15, 0.15.0 Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants