Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in what's new pages #2220

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Conversation

lgolston
Copy link
Contributor

Rationale

This fixes several broken links in the what's new pages in the documentation, and uses double backticks around deprecated methods if they weren't already being used.
As a note, in the what's new for v0.5 I found the call to :mod:cartopy.feature was not working because of currentmodule being used instead of module in feature.rst. For consistency, this change was then repeated in the .rst file for other modules.

Implications

I think issue #1972 can be closed.

Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

There are still a few warnings from the Sphinx build if you look at the CircleCI logs if you're interested in fixing up some other documentation references too.

@greglucas greglucas merged commit f9fa556 into SciTools:main Jul 23, 2023
13 checks passed
@greglucas greglucas added this to the 0.22 milestone Jul 23, 2023
@lgolston lgolston deleted the broken-links branch July 24, 2023 17:39
@lgolston lgolston mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants