Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add antarctic_ice_shelf_polys to downloaded data #2097

Merged

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Oct 22, 2022

Rationale

These data are quite useful for folks like me doing Antarctic research. We already include these data in the cartopy_offlinedata package on conda-forge.

Implications

Slightly more downloaded data for folks that don't work on Antarctica.

These data are quite useful for folks like me doing Antarctic
research.
@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2022

Testing

I made sure this works by running:

./tools/cartopy_feature_download.py -o ~/Desktop/cartopy_test gshhs physical cultural cultural-extra

As expected, I get the ne_10m_antarctic_ice_shelves_polys.* and ne_50m_antarctic_ice_shelves_polys.* files, along with the rest.

@xylar
Copy link
Contributor Author

xylar commented Oct 22, 2022

Here's an example usage:
https://github.com/MPAS-Dev/MPAS-Analysis/blob/develop/mpas_analysis/shared/plot/climatology_map.py#L778-L781
and a typical resulting image (from a very coarse resolution simulation):
image

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

@dopplershift dopplershift merged commit 9c84165 into SciTools:main Oct 24, 2022
@xylar xylar deleted the download_antarctic_ice_shelf_polys branch October 24, 2022 19:56
@xylar
Copy link
Contributor Author

xylar commented Oct 24, 2022

Thanks @dopplershift!

@QuLogic QuLogic added this to the 0.22 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants