Remove AD weak deps #780
Merged
Remove AD weak deps #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires: * SciML/PreallocationTools.jl#58 * SciML/RecursiveArrayTools.jl#247 * SciML/DiffEqBase.jl#871 Moving all of those to their rightful places instead of pirating now that a weak dependency system exists.
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
+ Coverage 61.63% 61.76% +0.12%
==========================================
Files 21 18 -3
Lines 4191 4064 -127
==========================================
- Hits 2583 2510 -73
+ Misses 1608 1554 -54
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChrisRackauckas
commented
Feb 8, 2023
ChrisRackauckas
added a commit
to SciML/DeepEquilibriumNetworks.jl
that referenced
this pull request
Feb 8, 2023
It really should just be removed for the one that's in SciMLSensitivity and be a FunctionOperator, but that can come later. Right now just trying to finish SciML/SciMLSensitivity.jl#780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Moving all of those to their rightful places instead of pirating now that a weak dependency system exists.