Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #242 : Pass IntegralProblem kwargs to solvers #244

Merged
merged 5 commits into from
Mar 3, 2024

Conversation

lxvm
Copy link
Collaborator

@lxvm lxvm commented Mar 2, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #242 . I first looked at how SimpleNonlinearSolve.jl does this and basically came up with the most simple solution to match. I also bumped the SciMLBase.jl version since otherwise some disallowed solver kwargs, like nout and batch, could potentially cause errors. (This scenario would be unlikely, i.e. someone mixing the old nout/batch interface with the new IntegralFunction interface, but I would rather avoid any errors if possible, which SciML/SciMLBase.jl#609 helped with by making it impossible for nout/batch to get stored as prob.kwargs.)

@ChrisRackauckas ChrisRackauckas merged commit 278d70f into SciML:master Mar 3, 2024
7 of 8 checks passed
@ChrisRackauckas ChrisRackauckas mentioned this pull request Mar 3, 2024
5 tasks
@lxvm lxvm deleted the kwargs branch March 3, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntegralProblem keywords not passed to solvers
2 participants