Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was interested in wrapping some of the GSL integration routines, which are unfortunately limited to 1d integration of scalar, real-valued functions. The main motivation is that the GSL has routines that claim to integrate singular functions and have robust adaptivity, which are helpful to have available for benchmarking algorithms and integrating certain functions. Part of the challenge of writing this extension, for me, is that GSL.jl is a low-level wrapper of the C library and I don't have much experience with memory management. It would be incredibly helpful for the reviewer to inspect the memory management, including the use of finalizers in
init_cacheval
and the call toBase.unsafe_convert
when constructing a runtime closure. Is there anything missing, such as calls toGC.@preserve
(see here)?Below, I mention a few additional todos below and an example of the usage is here
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
wssize
)Additional context
Add any other context about the problem here.