Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maxiters for CubaSUAVE #18

Closed
wants to merge 1 commit into from
Closed

Conversation

ChrisRackauckas
Copy link
Member

Fixes #17

@@ -112,7 +112,7 @@ function __init__()
function DiffEqBase.solve(prob::QuadratureProblem,
alg::AbstractCubatureJLAlgorithm, args...;
reltol = 1e-8, abstol = 1e-8,
maxiters = typemax(Int),
maxiters = alg isa CubaSUAVE ? 1000000 : typemax(Int),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong function. You want alg::AbstractCubaAlgorithm

@agerlach
Copy link
Collaborator

agerlach commented Jun 4, 2020

This RP is no longer needed. I implemented in the fix in #20

@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-1 branch June 4, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CubaSUAVE returning wrong result, NaN
2 participants