Simpler initial example, also highlight parameters #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README only shows how to perform multidimensional quadrature, and doesn't mention anything about how to use parameters. This PR adds a simple one-dimensional example that also uses parameters.
(In the actual documentation there are some examples of this, but maybe it's nice to also have it at the first thing users see. although the one-dimensional example of
my_sin(x) = solve(IntegralProblem((x, p) -> cos(x), 0.0, x), QuadGKJL()).uis a bit complicated for what users will most often want to do. Parameters are discussed in https://docs.sciml.ai/Integrals/stable/tutorials/differentiating_integrals/ which is maybe fine since it's mentioned at the start of the first tutorial.)