Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra kwargs #137

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Remove extra kwargs #137

merged 3 commits into from
Feb 3, 2023

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

@ArnoStrouwen
Copy link
Member Author

I'm guessing checking a string like

@test_throws "Unrecognized keyword arguments found." solve(prob, HCubatureJL();
                                                               relztol = 1e-3,
                                                               abstol = 1e-3)

Wasn't a thing yet in Julia version 1.6.

@ChrisRackauckas
Copy link
Member

No, but it should check the error exception that is returned instead of the string.

@ArnoStrouwen ArnoStrouwen changed the title [WIP] remove extra kwargs Remove extra kwargs Feb 3, 2023
@ArnoStrouwen
Copy link
Member Author

This is ready for review.

@ChrisRackauckas ChrisRackauckas merged commit 473b5a9 into SciML:master Feb 3, 2023
@ArnoStrouwen ArnoStrouwen deleted the interface branch February 3, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArnoStrouwen @ChrisRackauckas