Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zygote w/ nout > 1 and Batch errors #40

Closed
agerlach opened this issue Sep 4, 2020 · 4 comments
Closed

Zygote w/ nout > 1 and Batch errors #40

agerlach opened this issue Sep 4, 2020 · 4 comments

Comments

@agerlach
Copy link
Collaborator

agerlach commented Sep 4, 2020

Currently not working. See various commented out tests, e.g.
https://github.com/SciML/Quadrature.jl/blob/2fa4a7d10e213a1206f759310264b411b304e731/test/derivative_tests.jl#L153
@lxvm lxvm mentioned this issue Oct 30, 2023
Merged
@ChrisRackauckas
Copy link
Member

@lxvm you said the PR fixed these, did you try the tests? Maybe we can just uncomment them?

ChrisRackauckas added a commit that referenced this issue Nov 3, 2023
@ChrisRackauckas
Uncomment many AD tests
02e251c 
If passes, fixes #40
@ChrisRackauckas ChrisRackauckas mentioned this issue Nov 3, 2023
Closed
@lxvm
Copy link
Collaborator

lxvm commented Nov 3, 2023

Yes, I uncommented the associated tests in #175. In #191 the additional uncommented tests are for derivatives with respect to boundaries, which are missing for the forward pass, and missing for dim>1 in the reverse pass. I'll take a swing at it in the next week or two

@ChrisRackauckas
Copy link
Member

I see, so this can close. I'll mark the others as broken. In general it's just not good to have tests commented out and instead they should be @test_broken anyways, since that will let you know if they unbreak.

@lxvm
Copy link
Collaborator

lxvm commented Nov 3, 2023

Thanks for bearing with me! I'm still learning a lot about best practices for writing packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uncomment many AD tests SciML/Integrals.jl
4 participants
@agerlach @ChrisRackauckas @sharanry @lxvm