Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump slurm from 17.11.5 to 19.05.1 #25

Merged
merged 15 commits into from
Oct 7, 2019
Merged

Conversation

crazyguitar
Copy link
Contributor

Upgrade slurm to latest version 19.05.1

@mjstealey
Copy link
Member

@crazyguitar - Looks good to me, I haven't tested it, but assume that you've run this in your environment successfully?

@crazyguitar
Copy link
Contributor Author

Hi @mjstealey

Yes! I run it successfully! I think write some unit tests will be better.

To prevent this project broken, I will write tests before merge. Thx

@mjstealey
Copy link
Member

Yes! I run it successfully! I think write some unit tests will be better.

To prevent this project broken, I will write tests before merge. Thx

@crazyguitar - This is fantastic!
Look forward to seeing your work 👍

@crazyguitar
Copy link
Contributor Author

Hi @mjstealey

I wrote some tests based on your REAEME.md and my design philosophy was using GNU make. Moreover, I used pure bash syntax instead of some other unit test frameworks such as bats because I didn't assume others that they had installed those frameworks. Please help me review the code and give me some suggestions. Thank you so much.

BTW, there are some targets in the Makefile: build, test, lint:

$ make build # or just make
$ make lint  # use shellcheck
$ make test  # run all tests in test/test.sh

Also, I created another branch, 19.05.1, on my fork project and used Travis CI to check whether all tests are pass or not. Please refer to the test result and my .travisyml.

PS. .travis.yml doesn't include in this PR.

thanks,
chang-ning

@mjstealey mjstealey merged commit de1b938 into SciDAS:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants