New function Scenic.Script.arc/7 to add arcs to current path #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new operation arc to add arcs to current path.
This interface is also available on HTML Canvas API: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/arc
Motivation and Context
Today we only have 2 interfaces to have arcs:
Scenic.Script.draw_arc/4
: which draws an arc on a new path;Scenic.Script.arc_to/6
: which adds an arc on the current path.The need for a third arc operation is that none of the above functions provide a flexible interface for arcs as the nvgArc does.
So this new function arc have the same parameters as nvgArc, which gives a more flexible interface for drawing arcs.
Types of changes
not work as expected)
but make things better)
Checklist
Dependencies
This PR depends on changes on https://github.com/ScenicFramework/scenic_driver_local and can only be merged after ScenicFramework/scenic_driver_local#42