Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build workflow for Linux #26

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Add build workflow for Linux #26

merged 1 commit into from
Oct 8, 2023

Conversation

fire
Copy link
Contributor

@fire fire commented Oct 8, 2023

These changes enable automated builds for multiple platforms.

  • Looking for review and how to resolve the mac build error.
  • Upload the proper build rather than the entire build folder
  • Only build for Linux
  • Can submit only [windows, linux] for now
  • Build for windows from linux

@fire
Copy link
Contributor Author

fire commented Oct 8, 2023

See the actions on https://github.com/fire/CoACD

image

@fire fire changed the title Add build workflow for macOS, Windows, and Linux Add build workflow for Windows, and Linux Oct 8, 2023
@fire fire force-pushed the main branch 13 times, most recently from 5deaa60 to ada30e2 Compare October 8, 2023 17:58
@fire fire changed the title Add build workflow for Windows, and Linux Add build workflow for Linux Oct 8, 2023
@fire fire marked this pull request as ready for review October 8, 2023 18:51
@eliphatfs
Copy link
Collaborator

eliphatfs commented Oct 8, 2023

Thanks for the work on setting up CI for CoACD!
We will merge the pull request after checking the code.
It would be great if you could also include building pip wheels in the actions.

@eliphatfs eliphatfs added the enhancement New feature or request label Oct 8, 2023
@fire
Copy link
Contributor Author

fire commented Oct 8, 2023

I agree, but I am wanting to do it in a secondary pr for python pip.

@fire
Copy link
Contributor Author

fire commented Oct 8, 2023

Doing windows c++ executable and macos executable caused me to be stuck for most of today so don't think they're easy to do, but I wanted some progress.

I don't think I can figure out how to do Windows or MacOS today. Catch you all another time. I'll still be avaliable for fixing the linux actions though.

@SarahWeiii SarahWeiii merged commit 26fef60 into SarahWeiii:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants